Skip to content

CORENET-6746: Allow EgressIP NoMatchingNodeFound events to repeat pathologically - #31614

Open
pperiyasamy wants to merge 1 commit into
openshift:mainfrom
pperiyasamy:ignore_eip_pathological_event
Open

CORENET-6746: Allow EgressIP NoMatchingNodeFound events to repeat pathologically#31614
pperiyasamy wants to merge 1 commit into
openshift:mainfrom
pperiyasamy:ignore_eip_pathological_event

Conversation

@pperiyasamy

@pperiyasamy pperiyasamy commented Sep 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

EgressIP e2e tests create EgressIP resources before labeling nodes with k8s.ovn.org/egress-assignable, causing NoMatchingNodeFound events to fire repeatedly until the label is applied. This is expected test behavior and should not be flagged as a pathological event.

Sample runs:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/3227/pull-ci-openshift-ovn-kubernetes-main-e2e-aws-core-networking-serial-ote/2095870485823754240
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/3227/pull-ci-openshift-ovn-kubernetes-main-e2e-azure-core-networking-serial-ote/2095870485857308672

Summary by CodeRabbit

  • New Features
    • Added matching support for repeated EgressIP test events that occur before nodes receive the required egress-assignable label.

@pperiyasamy @claude
Allow EgressIP NoMatchingNodeFound events to repeat pathologically
02ae777 
EgressIP e2e tests create EgressIP resources before labeling nodes
with k8s.ovn.org/egress-assignable, causing NoMatchingNodeFound events
to fire repeatedly until the label is applied. This is expected test
behavior and should not be flagged as a pathological event.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 09763439-a613-491b-84b5-6a7a7c93af1a

📥 Commits

Reviewing files that changed from the base of the PR and between 33306d2 and 02ae777.

📒 Files selected for processing (1)
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The change registers a universal pathological-event matcher for repeated NoMatchingNodeFound events from EgressIP tests before nodes receive the required assignable label.

Changes

EgressIP event matching

Layer / File(s) Summary
Register EgressIP matcher
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go		 Registers EgressIPNoMatchingNodeFound for NoMatchingNodeFound events that report no assignable EgressIP nodes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 02ae7

This allows expected repeated EgressIP NoMatchingNodeFound test events before node labeling without a remaining merge-blocking risk.

Suggested reviewers: mdbooth

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The pull request changes only duplicated_event_patterns.go and adds a static matcher identifier, EgressIPNoMatchingNodeFound. The added code contains no Ginkgo test declarations or test titl…
Test Structure And Quality ✅ Passed PASS: The pull request changes only pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go and adds a SimplePathologicalEventMatcher registration. It does not add or modify G…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go and adds a SimplePathologicalEventMatcher for existing EgressIP events. The diff ad…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS. The pull request changes only pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go and adds a pathological-event matcher. The diff adds no Ginkgo tests or test construc…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR changes only pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go. The diff adds a SimplePathologicalEventMatcher for repeated NoMatchingNodeFound events. It…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only duplicated_event_patterns.go and adds a SimplePathologicalEventMatcher with comments and regular expressions. The added code performs no stdout write, logging c…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go. It adds a pathological-event matcher inside NewUniversalPathologicalEventMatchers; it do…
No-Weak-Crypto ✅ Passed PASS: The PR adds only a SimplePathologicalEventMatcher with two regular expressions and a registry call. The exact diff adds no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, cryptographic API, custom c…
Container-Privileges ✅ Passed PASS. The commit changes only one Go source file and adds a pathological-event matcher. It does not add or modify a container or Kubernetes manifest, and the added lines contain none of the checked pr…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds only a pathological-event matcher and comments. It adds no logging statements, credentials, tokens, hostnames, or customer data. The existing matcher registry logs event fields f…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the EgressIP change and the repeated NoMatchingNodeFound events. It accurately summarizes the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Sep 7, 2026
@pperiyasamy pperiyasamy changed the title Allow EgressIP NoMatchingNodeFound events to repeat pathologically CORENET-6746: Allow EgressIP NoMatchingNodeFound events to repeat pathologically Sep 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 7, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@pperiyasamy: This pull request references CORENET-6746 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

EgressIP e2e tests create EgressIP resources before labeling nodes with k8s.ovn.org/egress-assignable, causing NoMatchingNodeFound events to fire repeatedly until the label is applied. This is expected test behavior and should not be flagged as a pathological event.

Sample runs:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/3227/pull-ci-openshift-ovn-kubernetes-main-e2e-aws-core-networking-serial-ote/2095870485823754240
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/3227/pull-ci-openshift-ovn-kubernetes-main-e2e-azure-core-networking-serial-ote/2095870485857308672

Summary by CodeRabbit

  • New Features
  • Added matching support for repeated EgressIP test events that occur before nodes receive the required egress-assignable label.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 7, 2026
@pperiyasamy

pperiyasamy commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

/assign @tssurya @dgoodwin

@pperiyasamy

pperiyasamy commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

/testwith openshift/ovn-kubernetes/main/e2e-aws-core-networking-serial-ote openshift/ovn-kubernetes#3227

tssurya
tssurya approved these changes Sep 7, 2026
View reviewed changes

@tssurya tssurya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

this feature works this way and ideally the users are expected to label node before creating EIP but doing it in reverse should work and that's what the tests are checking

please double check this with test-with-pr to see if this solves the issue
you'll need approve from QSE or TRT teams I think

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2026
@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy, tssurya
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgoodwin. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

openshift-merge-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@pperiyasamy

pperiyasamy commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 7, 2026

Copy link
Copy Markdown

@pperiyasamy: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy pperiyasamy mentioned this pull request Sep 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial
@sjenning sjenning Awaiting requested review from sjenning
+1 more reviewer
@tssurya tssurya tssurya approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dgoodwin dgoodwin

@tssurya tssurya

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pperiyasamy @openshift-ci-robot @tssurya @dgoodwin